Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly delete SphinxDomain objects from previous versions #5945

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 17, 2019

This has to be done before deleting ImportedFiles and not with a cascade,
because multiple Domain's can reference a specific HTMLFile.

This has to be done before deleting ImportedFiles and not with a cascade,
because multiple Domain's can reference a specific HTMLFile.
@ericholscher ericholscher requested review from dojutsu-user and Jul 17, 2019
Copy link
Member

@dojutsu-user dojutsu-user left a comment

This looks good.

@ericholscher ericholscher merged commit 5390828 into master Jul 17, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix-sphinxdomain-delete branch Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants