Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update external version check for notification task #5969

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jul 20, 2019

We should not check if the version is external inside the task. we should check it before we call the task. this will reduce the number of unnecessary celery tasks called.

@saadmk11 saadmk11 requested a review from ericholscher Jul 20, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Jul 20, 2019
@saadmk11 saadmk11 changed the title update notification task for external versions update external version check for notification task Jul 20, 2019
Copy link
Member

@humitos humitos left a comment

This makes a lot of sense!

stsewd
stsewd approved these changes Jul 22, 2019
@ericholscher ericholscher merged commit c79211a into readthedocs:master Jul 22, 2019
1 check passed
Pull Request Builder automation moved this from In progress to Done Jul 22, 2019
@saadmk11 saadmk11 deleted the webhook-notification branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants