Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitpython #5974

Merged
merged 2 commits into from Jul 23, 2019
Merged

Update gitpython #5974

merged 2 commits into from Jul 23, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 22, 2019

Gitpython not longer fails when the path from a submodule isn't find.
New release drops support for python2, we are fully python3.

This removes the msg added in #5903 since gitpython not longer fails in those cases.

Closes #4371

Gitpython not longer fails when the path from a submodule isn't find.
New release drops support for python2, we are fully python3.
@stsewd stsewd requested a review from Jul 22, 2019
Copy link
Member

@humitos humitos left a comment

LGTM!

Now, if there is an invalid submodule, instead of failing the build, it will just continue?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Jul 23, 2019

Now, if there is an invalid submodule, instead of failing the build, it will just continue?

Yep

@stsewd stsewd merged commit 787efca into readthedocs:master Jul 23, 2019
1 check passed
@stsewd stsewd deleted the update-gitpython branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants