Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit tests for version managers #5981

Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 23, 2019

This makes more explicit what results we are expecting.

And also fix this

self.assertNotIn(self.internal_versions, Version.external.private())

That always evaluates to true (both are querysets)

That needs to be fixed in the other tests that are in this file. /cc @saadmk11

@stsewd stsewd requested review from saadmk11 and Jul 23, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Jul 23, 2019

Copy link
Member

@saadmk11 saadmk11 left a comment

Looks good to me Thanks for the Update 💯

self.assertNotIn(self.internal_versions, Version.external.private())

This was a silly mistake. :( I'll fix this in another PR.

@ericholscher ericholscher merged commit 7bdfec7 into readthedocs:master Jul 26, 2019
1 check passed
@stsewd stsewd deleted the more-explicit-tests-for-managers branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants