Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing list.extend line when appending conda dependencies #5986

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jul 24, 2019

It seems that in the last minute refactor of #5956 I deleted an important line that adds our conda core dependencies to the environment.yml file.

Now we are only adding our pip core dependencies, which is half of the work needed.

@humitos humitos requested review from and ericholscher Jul 24, 2019
Copy link
Contributor

@agjohnson agjohnson left a comment

Fix looks good 👍

Loading

@agjohnson agjohnson merged commit 00b14ba into master Jul 25, 2019
2 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the humitos/append-core-deps-conda branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants