Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manager and description field to AutomationRule model #5995

Merged
merged 9 commits into from Aug 26, 2019

Clean up

  • Loading branch information...
stsewd committed Aug 1, 2019
commit 97a4a991dd7334a4d2a8a4d75b9f73448cbb6e8d
@@ -196,6 +196,7 @@ def append_rule(
last_priority = (
project.automation_rules
.values_list('priority', flat=True)
.order_by('priority')
.last()
)
This conversation was marked as resolved by stsewd

This comment has been minimized.

Copy link
@ericholscher

ericholscher Jul 31, 2019

Member

This should probably have an explicit order_by, no?

if last_priority is None:
@@ -1007,10 +1007,6 @@ def get_description(self):
return self.description
return f'{self.get_action_display()}'

@property
def edit_url(self):
raise NotImplementedError

def __str__(self):
class_name = self.__class__.__name__
return (
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.