Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic involving creation of Sphinx Domains #5997

Merged
merged 5 commits into from Jul 26, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jul 25, 2019

This is just a work around.
We should fix the original issue: #5821

readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
@dojutsu-user dojutsu-user requested a review from Jul 25, 2019
@dojutsu-user dojutsu-user added this to In progress in In-doc search UI via automation Jul 25, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This could probably use a test, if it's easy enough to test.

readthedocs/search/documents.py Outdated Show resolved Hide resolved
Copy link
Member

@ericholscher ericholscher left a comment

Thanks for the test. 👍

@ericholscher ericholscher merged commit 6935ddf into readthedocs:master Jul 26, 2019
1 check passed
@dojutsu-user dojutsu-user deleted the add-more-loggers branch Jul 26, 2019
@dojutsu-user dojutsu-user moved this from In progress to Done in In-doc search UI Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants