Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the scope between before_vcs and after_vcs #6015

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 30, 2019

This makes it include submodule cloning.
This is mainly to include the SSH agent during submodule cloning on the corporate site.

This makes it include submodule cloning.
This is mainly to include the SSH agent during submodule cloning on the corporate site.
@ericholscher ericholscher requested review from stsewd and Jul 30, 2019
stsewd
stsewd approved these changes Jul 30, 2019
@@ -264,6 +261,9 @@ def run(self, version_pk): # pylint: disable=arguments-differ
},
},
)
finally:
after_vcs.send(sender=self.version)
Copy link
Member

@stsewd stsewd Jul 30, 2019

Suggested change
after_vcs.send(sender=self.version)
after_vcs.send(sender=self.version)

@@ -238,6 +234,7 @@ def run(self, version_pk): # pylint: disable=arguments-differ
:rtype: bool
"""
try:
before_vcs.send(sender=self.version)
Copy link
Member

@stsewd stsewd Jul 30, 2019

This should be below self.project = ...

Copy link
Member Author

@ericholscher ericholscher Jul 30, 2019

ha, true

@ericholscher ericholscher merged commit 9a9228c into master Jul 30, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the expand-vcs-signal-scope branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants