Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_absolute_url for External Versions #6020

Merged
merged 3 commits into from Jul 31, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 31, 2019

This allows us to properly set a new domain in production for the external version hosting.
It's a bit hacky for now,
mostly because we don't have a way to specify HTML or PDF versions of the external versions.

We will need to think more about the UX around multiple types,
but that's also an existing issue with our current doc builds (we only link to HTML).

This allows us to properly set a new domain in production for the external version hosting.
It's a bit hacky for now,
mostly because we don't have a way to specify HTML or PDF versions of the external versions.

We will need to think more about the UX around multiple types,
but that's also an existing issue with our current doc builds (we only link to HTML).
@ericholscher ericholscher requested a review from saadmk11 Jul 31, 2019
Copy link
Member

@saadmk11 saadmk11 left a comment

This looks good and this is what I did in the first place but I changed it because we won't be able to do this
https://docs.readthedocs.io/32/ we have to have a file name and extension https://docs.readthedocs.io/32/index.html.
if thats not an issue then I think it good enough

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 31, 2019

Yea, the local serving is a bit weak, but it isn't too much of a worry. We will be changing up how all this works soon, so that's why I'm trying to keep it simple.

@ericholscher ericholscher merged commit 2b470e4 into master Jul 31, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the external-version-url-update branch Jul 31, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 1, 2019
@saadmk11 saadmk11 moved this from In progress to Done in Pull Request Builder Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants