Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show wipe version message on build details page for External versions #6034

merged 2 commits into from Aug 7, 2019


Copy link

@saadmk11 saadmk11 commented Aug 2, 2019

We should not show wipe version message on the build details page for external versions as we disabled wipe version functionality for external versions.

def wipe_version(request, project_slug, version_slug):
version = get_object_or_404(

@saadmk11 saadmk11 requested review from ericholscher and Aug 2, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 2, 2019
Copy link

@ericholscher ericholscher left a comment

Makes sense. I wonder if this should check something more explicit, like build.supports_wipe that we can just add that logic in one place?

Copy link
Member Author

@saadmk11 saadmk11 commented Aug 6, 2019

Yeah we can do that :)

Copy link
Member Author

@saadmk11 saadmk11 commented Aug 7, 2019

@ericholscher Updated the PR.

@saadmk11 saadmk11 requested a review from ericholscher Aug 7, 2019
@ericholscher ericholscher merged commit c051b16 into readthedocs:master Aug 7, 2019
1 check passed
Pull Request Builder automation moved this from In progress to Done Aug 7, 2019
@saadmk11 saadmk11 deleted the update-build-details branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants