Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete media storage files for external version #6035

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Aug 2, 2019

We should not delete the external version files from the storage so that the links sent through GitHub Status API still work.

@saadmk11 saadmk11 requested review from ericholscher and Aug 2, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 2, 2019
@ericholscher ericholscher merged commit 9601195 into readthedocs:master Aug 6, 2019
1 check passed
Pull Request Builder automation moved this from In progress to Done Aug 6, 2019
@saadmk11 saadmk11 deleted the dont-delete-media branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants