Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RTD prefix for docker only in setting.py and all other places where is needed #6040

Merged
merged 4 commits into from Oct 10, 2019

Conversation

@Iamshankhadeep
Copy link
Contributor

Iamshankhadeep commented Aug 5, 2019

fixes #5586

@stale

This comment has been minimized.

Copy link

stale bot commented Sep 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale label Sep 19, 2019
@stsewd stsewd requested review from stsewd and readthedocs/core Sep 19, 2019
@Iamshankhadeep Iamshankhadeep force-pushed the Iamshankhadeep:adding_rtd_prefix branch from 2a33e53 to 90328f2 Sep 20, 2019
@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

Iamshankhadeep commented Sep 22, 2019

@stsewd can you review it?

Copy link
Member

stsewd left a comment

Thanks, there are still some places to update

https://github.com/readthedocs/readthedocs.org/blob/master/docs/development/buildenvironments.rst
https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/settings/dev.py

Returns supported versions for the ``DOCKER_DEFAULT_VERSION`` if not

``settings.DOCKER_ENABLE`` is used)

If :py:data:`settings.DOCKER_ENABLE` is true, build documentation inside a

@Iamshankhadeep Iamshankhadeep requested a review from stsewd Sep 29, 2019
@stsewd
stsewd approved these changes Sep 30, 2019
Copy link
Member

stsewd left a comment

Thanks!

@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

Iamshankhadeep commented Oct 1, 2019

Nice 2 work done. now lets focus on new issues.

@humitos humitos merged commit 6f3a980 into readthedocs:master Oct 10, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.