Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort versions taking into consideration the vcs type #6049

Merged
merged 4 commits into from Aug 8, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Aug 8, 2019

Ref #6010 (comment)

@stsewd stsewd requested review from davidfischer and Aug 8, 2019
)

def test_sort_svn_trunk(self):
identifiers = ['/trunk/', '1.0', '2.0', '1.1', '1.9', '1.10']
Copy link
Member Author

@stsewd stsewd Aug 8, 2019

not really sure about this one, but it's as fallback_branch, so 🤷‍♂️

and not like we have many of these 👀

Copy link
Member

@ericholscher ericholscher left a comment

Makes sense.

readthedocs/projects/version_handling.py Outdated Show resolved Hide resolved
Co-Authored-By: David Fischer <djfische@gmail.com>
@stsewd stsewd merged commit 1e8b273 into readthedocs:master Aug 8, 2019
1 check passed
@stsewd stsewd deleted the sort-versions-vcs branch Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants