Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indelx.html filename to the external doc url #6051

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Aug 8, 2019

No description provided.

@saadmk11 saadmk11 requested a review from ericholscher Aug 8, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 8, 2019
@saadmk11 saadmk11 changed the title Added indelx.html filename to the external doc url Add indelx.html filename to the external doc url Aug 8, 2019
@ericholscher ericholscher merged commit 7970d0a into readthedocs:master Aug 8, 2019
1 check passed
Pull Request Builder automation moved this from In progress to Done Aug 8, 2019
@saadmk11 saadmk11 deleted the external-doc-url-fix branch Aug 8, 2019
if settings.DEBUG:
url += 'index.html'
url = f'{settings.EXTERNAL_VERSION_URL}/html/' \
f'{self.project.slug}/{self.slug}/index.html'
Copy link
Member

@stsewd stsewd Aug 8, 2019

This could be written like

url = (
    f'some string'
    f'another string'
)

That way we don't use \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants