Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Builder GitLab Integration #6066

Merged
merged 10 commits into from Aug 19, 2019
Merged

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Aug 11, 2019

ref: #6052

@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 11, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This looks good. A few small nits, but I think it's close.

Loading

readthedocs/api/v2/views/integrations.py Outdated Show resolved Hide resolved
Loading
return identifier, verbose_name

except KeyError:
raise ParseError('Parameters "id" and "iid" are required')
Copy link
Member

@ericholscher ericholscher Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this ParseError handled?

Loading

Copy link
Member Author

@saadmk11 saadmk11 Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is a ParseError we return 400 to the API. We do the same thing for the push events.

try:
branches = [self._normalize_ref(data['ref'])]
return self.get_response_push(self.project, branches)
except KeyError:
raise ParseError('Parameter "ref" is required')

Loading

readthedocs/rtd_tests/tests/test_project.py Show resolved Hide resolved
Loading
saadmk11 and others added 3 commits Aug 13, 2019
Co-Authored-By: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Copy link
Member

@ericholscher ericholscher left a comment

👍

Loading

@ericholscher ericholscher merged commit 3ccf7c3 into readthedocs:master Aug 19, 2019
2 checks passed
Loading
Pull Request Builder automation moved this from In progress to Done Aug 19, 2019
@saadmk11 saadmk11 deleted the gitlab-integration branch Aug 19, 2019
@saadmk11 saadmk11 mentioned this pull request Aug 20, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants