Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Builder GitLab Integration #6066

Merged
merged 10 commits into from Aug 19, 2019

Conversation

@saadmk11
Copy link
Member

commented Aug 11, 2019

ref: #6052

@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 11, 2019

saadmk11 added 6 commits Aug 11, 2019

@saadmk11 saadmk11 requested review from ericholscher and readthedocs/core Aug 12, 2019

@ericholscher
Copy link
Member

left a comment

This looks good. A few small nits, but I think it's close.

readthedocs/api/v2/views/integrations.py Outdated Show resolved Hide resolved
return identifier, verbose_name

except KeyError:
raise ParseError('Parameters "id" and "iid" are required')

This comment has been minimized.

Copy link
@ericholscher

ericholscher Aug 12, 2019

Member

Where is this ParseError handled?

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Aug 13, 2019

Author Member

When there is a ParseError we return 400 to the API. We do the same thing for the push events.

try:
branches = [self._normalize_ref(data['ref'])]
return self.get_response_push(self.project, branches)
except KeyError:
raise ParseError('Parameter "ref" is required')

saadmk11 and others added 3 commits Aug 13, 2019
Update readthedocs/api/v2/views/integrations.py
Co-Authored-By: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@ericholscher
Copy link
Member

left a comment

👍

@ericholscher ericholscher merged commit 3ccf7c3 into readthedocs:master Aug 19, 2019

2 checks passed

continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Builder automation moved this from In progress to Done Aug 19, 2019

@saadmk11 saadmk11 deleted the saadmk11:gitlab-integration branch Aug 19, 2019

@saadmk11 saadmk11 referenced this pull request Aug 20, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.