Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Sync and Re-Sync for Manually Created Integrations #6071

Merged
merged 12 commits into from Aug 20, 2019

Conversation

@saadmk11
Copy link
Member

commented Aug 13, 2019

A lot of work needs to be done and a lot of cases needs to be handled before its ready for review. :)
closes #3932

related to the first step of #6052

saadmk11 added 7 commits Aug 14, 2019

@saadmk11 saadmk11 requested review from ericholscher, humitos and readthedocs/core Aug 14, 2019

@saadmk11 saadmk11 changed the title Auto Sync and Re-Sync Manually Created integrations Auto Sync and Re-Sync for Manually Created Integrations Aug 15, 2019

@ericholscher
Copy link
Member

left a comment

This looks good, I think we can do a bit more to make this flow nice, by showing the user the webhook URL & secret always.

integration is not functioning correctly, try resyncing the webhook:
This webhook was configured when this project was imported
or it was manually created with correct configuration. If this
integration is not functioning correctly, try re-syncing the webhook:

This comment has been minimized.

Copy link
@ericholscher

ericholscher Aug 19, 2019

Member

This looks good, but I'd like to see us always displaying the webhook URL information, so that users can confirm that the automated webhook is the one they see in their GitHub admin. We should always show this data.

@ericholscher

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

BTW, this is so much better than making users login to GitHub and create the webhook manually. This is a huge win!

saadmk11 and others added 3 commits Aug 19, 2019
Update readthedocs/templates/projects/integration_webhook_detail.html
Co-Authored-By: Eric Holscher <25510+ericholscher@users.noreply.github.com>

@saadmk11 saadmk11 requested a review from ericholscher Aug 20, 2019

@saadmk11

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

@ericholscher ready for a full review :)

@saadmk11 saadmk11 requested a review from readthedocs/core Aug 20, 2019

@ericholscher
Copy link
Member

left a comment

This looks good with one small change 👍

user_pk=self.request.user.pk,
integration=self.object
)
if self.object.integration_type != Integration.API_WEBHOOK:

This comment has been minimized.

Copy link
@ericholscher

ericholscher Aug 20, 2019

Member

Do we not have some kind of has_sync check here? I feel like this might break in the future as we add new types of Integration.

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Aug 20, 2019

Author Member

Thanks. I think what you said would be better. :)

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Aug 20, 2019

Author Member

@ericholscher Updated the PR!

@saadmk11 saadmk11 referenced this pull request Aug 20, 2019
3 of 3 tasks complete

@saadmk11 saadmk11 closed this Aug 20, 2019

@saadmk11 saadmk11 reopened this Aug 20, 2019

@ericholscher ericholscher merged commit 5c03027 into readthedocs:master Aug 20, 2019

2 checks passed

continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saadmk11 saadmk11 deleted the saadmk11:webhook-sync branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.