Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab Build Status Reporting for PR Builder #6076

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@saadmk11
Copy link
Member

commented Aug 16, 2019

This PR is created on top of #6066. PR: #6066 should be merged first.

ref: #6052

@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 16, 2019

@saadmk11 saadmk11 requested review from ericholscher and readthedocs/core Aug 17, 2019

Pull Request Builder automation moved this from In progress to Done Aug 19, 2019

@ericholscher ericholscher reopened this Aug 19, 2019

Pull Request Builder automation moved this from Done to In progress Aug 19, 2019

@ericholscher

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Was hoping that would rebase the commits, but we need to update this now that #6066 is merged.

@saadmk11 saadmk11 force-pushed the saadmk11:gitlab-build-status branch from cda0762 to b4e7834 Aug 19, 2019

@saadmk11

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

@ericholscher Updated the PR

@saadmk11 saadmk11 referenced this pull request Aug 20, 2019
3 of 3 tasks complete
@ericholscher
Copy link
Member

left a comment

Seems pretty straightforward, and similar to GH. 👍

@@ -356,8 +356,8 @@ def test_send_build_status_task_with_remote_repo(self, send_build_status):
)
self.assertEqual(Message.objects.filter(user=self.eric).count(), 0)

@patch('readthedocs.projects.tasks.GitHubService.send_build_status')
def test_send_build_status_task_with_social_account(self, send_build_status):
@patch('readthedocs.oauth.services.github.GitHubService.send_build_status')

This comment has been minimized.

Copy link
@ericholscher

ericholscher Aug 20, 2019

Member

Why did this change? It seems like it was wrong before?

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Aug 20, 2019

Author Member

Because we are not directly importing GitHubService to the tasks we are using project.git_service_class()

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Aug 20, 2019

Author Member

It was working before because I forgot to remove an unused import of GitHubService

@ericholscher ericholscher merged commit 12ec907 into readthedocs:master Aug 20, 2019

2 checks passed

continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Builder automation moved this from In progress to Done Aug 20, 2019

@saadmk11 saadmk11 deleted the saadmk11:gitlab-build-status branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.