Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab Build Status Reporting for PR Builder #6076

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Aug 16, 2019

This PR is created on top of #6066. PR: #6066 should be merged first.

ref: #6052

@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 16, 2019
@saadmk11 saadmk11 requested review from ericholscher and Aug 17, 2019
Pull Request Builder automation moved this from In progress to Done Aug 19, 2019
@ericholscher ericholscher reopened this Aug 19, 2019
Pull Request Builder automation moved this from Done to In progress Aug 19, 2019
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Aug 19, 2019

Was hoping that would rebase the commits, but we need to update this now that #6066 is merged.

Loading

@saadmk11 saadmk11 force-pushed the gitlab-build-status branch from cda0762 to b4e7834 Aug 19, 2019
@saadmk11
Copy link
Member Author

@saadmk11 saadmk11 commented Aug 19, 2019

@ericholscher Updated the PR

Loading

@saadmk11 saadmk11 mentioned this pull request Aug 20, 2019
3 tasks
Copy link
Member

@ericholscher ericholscher left a comment

Seems pretty straightforward, and similar to GH. 👍

Loading

@@ -356,8 +356,8 @@ def test_send_build_status_task_with_remote_repo(self, send_build_status):
)
self.assertEqual(Message.objects.filter(user=self.eric).count(), 0)

@patch('readthedocs.projects.tasks.GitHubService.send_build_status')
def test_send_build_status_task_with_social_account(self, send_build_status):
@patch('readthedocs.oauth.services.github.GitHubService.send_build_status')
Copy link
Member

@ericholscher ericholscher Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change? It seems like it was wrong before?

Loading

Copy link
Member Author

@saadmk11 saadmk11 Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are not directly importing GitHubService to the tasks we are using project.git_service_class()

Loading

Copy link
Member Author

@saadmk11 saadmk11 Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was working before because I forgot to remove an unused import of GitHubService

Loading

@ericholscher ericholscher merged commit 12ec907 into readthedocs:master Aug 20, 2019
2 checks passed
Loading
Pull Request Builder automation moved this from In progress to Done Aug 20, 2019
@saadmk11 saadmk11 deleted the gitlab-build-status branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants