Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR Builder guide to docs #6093

Merged
merged 8 commits into from Sep 9, 2019

Conversation

@saadmk11
Copy link
Member

commented Aug 22, 2019

No description provided.

@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Aug 22, 2019
@saadmk11 saadmk11 closed this Aug 22, 2019
Pull Request Builder automation moved this from In progress to Done Aug 22, 2019
@saadmk11 saadmk11 reopened this Aug 22, 2019
Pull Request Builder automation moved this from Done to In progress Aug 22, 2019
saadmk11 added 2 commits Aug 22, 2019
@saadmk11 saadmk11 requested review from ericholscher and readthedocs/core Aug 22, 2019
@stsewd

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Shouldn't this be in the features section? Looks more like explaining the feature rather than a guide

@saadmk11

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

Shouldn't this be in the features section? Looks more like explaining the feature rather than a guide

Okay, I'll add it in the feature section :)

@ericholscher

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

I think we need to think a bit more about this -- it's way too much content for the current implementation of features. I wonder if we need a proper marketing site readthedocs.org/features/ vs. the current features section of the docs?

@saadmk11

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

I think we need to think a bit more about this -- it's way too much content for the current implementation of features. I wonder if we need a proper marketing site readthedocs.org/features/ vs. the current features section of the docs?

We can have something like that to show all our features and we can also promote new features.

Copy link
Member

left a comment

Not great feedback, but some comments.

docs/guides/autobuild-docs-for-pull-requests.rst Outdated Show resolved Hide resolved
docs/guides/autobuild-docs-for-pull-requests.rst Outdated Show resolved Hide resolved
docs/guides/autobuild-docs-for-pull-requests.rst Outdated Show resolved Hide resolved
docs/guides/autobuild-docs-for-pull-requests.rst Outdated Show resolved Hide resolved
docs/guides/autobuild-docs-for-pull-requests.rst Outdated Show resolved Hide resolved
Learn more about setting up webhooks from our :doc:`Webhook Documentation </webhooks>`.

If you have tried all the above troubleshooting and still getting issues,
please let us know by opening an `issue`_ on our GitHub Repository.

This comment has been minimized.

Copy link
@humitos

humitos Sep 3, 2019

Member

I think we agreed that people should send us an email for this kind of issues.

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Sep 3, 2019

Author Member

I think email was only for enabling this feature. I'll add email instead of issue.

@humitos

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

it's way too much content for the current implementation of features. I wonder if we need a proper marketing site readthedocs.org/features/ vs. the current features section of the docs?

I may agree with you, Eric. Although, I think that moving the "Features" section from our docs to its own page is a ton of work. I'd prefer to work more in our docs by making them more clear and removing redundant things as a first step (that's it #5771)

saadmk11 and others added 4 commits Sep 3, 2019
Co-Authored-By: Manuel Kaufmann <humitos@gmail.com>
Co-Authored-By: Manuel Kaufmann <humitos@gmail.com>
@ericholscher

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I think this approach is better than nothing, so I'm going to merge it, and we can build out a proper features section later once we have time.

@ericholscher ericholscher merged commit 390a4ce into readthedocs:master Sep 9, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Builder automation moved this from In progress to Done Sep 9, 2019
@saadmk11 saadmk11 deleted the saadmk11:pr-builder-guide branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.