Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "Edit Versions" listing to the Admin menu #6110

Merged
merged 2 commits into from Dec 10, 2019
Merged

Conversation

@ericholscher
Copy link
Member

ericholscher commented Aug 27, 2019

This will let users easily find the current version editing UI,
and be the place we'll eventually move it after a refactor.

This will let users easily find the current version editing UI,
and be the place we'll eventually move it after a refactor.
@ericholscher ericholscher requested a review from readthedocs/core Aug 27, 2019
@humitos
humitos approved these changes Oct 2, 2019
Copy link
Member

humitos left a comment

I usually don't like to have two ways of doing the same thing. I think this was the one of reasons why we deleted the Edit Version form from here. Although, it seems that removing this has been confusing users (I didn't hear anything about, but I suppose you did and that's why you are considering this changeset) and considering that we are adding just a link to the Version listing page and not a new one, I'm fine with this change for now.

@agjohnson

This comment has been minimized.

Copy link
Contributor

agjohnson commented Oct 2, 2019

To clarify, we had some conversations around this: we removed the wrong UI. Or rather, we should have moved the dashboard version list page into the admin dashboard, replacing that mess of a UI. I might have originally brought up the idea to remove the dashboard version page, but I might not have been clear that the project dashboard version list page is the one that is unnecessary.

We already have a version list on the project dashboard page, the version listing page therefore is redundant for reader users, and the admin interactions that a maintainer takes shouldn't be on the project dashboard, but should be on the admin dashboard instead.

So the ultimate plan is to backtrack a little on this change, move the existing UI into the admin dashboard, and remove the dashboard version listing page. We'll likely have to do the reverse linking then and temporarily link the project dashboard version button to the admin dashboard version listing view.

@humitos

This comment has been minimized.

Copy link
Member

humitos commented Oct 9, 2019

So the ultimate plan is to backtrack a little on this change, move the existing UI into the admin dashboard, and remove the dashboard version listing page.

Removing the dashboard listing page, will remove this page https://readthedocs.org/projects/sphinx-hoverxref/versions/ that is accessible for anonymous users. In that page, you can see all the active versions and their docs. Although, the same behavior is at the project home page as well: https://readthedocs.org/projects/sphinx-hoverxref/

@agjohnson

This comment has been minimized.

Copy link
Contributor

agjohnson commented Oct 14, 2019

Although, the same behavior is at the project home page as well

Yup, that's my point above. The project dashboard version list view is not a helpful view for reader users and can be removed entirely. Leo was already instructed to make this change in the project spec, but we removed the wrong UI.

Copy link
Contributor

agjohnson left a comment

Raised on a previous conversation, I think the version link should be bumped up in the list to where it was originally. Change looks good otherwise 👍

@stale

This comment has been minimized.

Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale label Nov 28, 2019
@stale stale bot closed this Dec 5, 2019
@ericholscher ericholscher reopened this Dec 10, 2019
@stale stale bot removed the Status: stale label Dec 10, 2019
@agjohnson agjohnson merged commit f193d76 into master Dec 10, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@agjohnson agjohnson deleted the edit-versions-hack branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.