Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extend DomainCreate view #6139

Merged
merged 3 commits into from Sep 23, 2019

Conversation

@humitos
Copy link
Member

commented Sep 5, 2019

This has no affect in Community. The change is to allow us to do something different in Corporate (redirect to Domain details after creation).

@humitos humitos requested review from agjohnson and readthedocs/core Sep 5, 2019
@ericholscher

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

Is there a reason we don't want to have the same logic on the community site?

@stsewd
stsewd approved these changes Sep 5, 2019
@humitos

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

@ericholscher yes.

Basically, what I'm adding in the corporate site is a redirect to the Domain details once it's created, because the user needs to know there are some extra steps they need to setup.

This is not exactly the same case in community. We could show the message saying "Add a CNAME pointing to readthedocs.io" if we want, but we will need more work in the community template as well.

agjohnson added 2 commits Sep 19, 2019
We need to inject a number of context data pieces for the template, it's
easiest to extend this class.
@agjohnson

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

I think that the logic should be the same, and there is a PR open for starting to make this UI use the correct patterns, but I'm fine accepting this as a solution for now.

I've pushed up 500f4a2 to also extend the update view, which we use to inject context data into the template. Re-requesting review.

@agjohnson agjohnson requested review from stsewd and readthedocs/core Sep 19, 2019
@stsewd
stsewd approved these changes Sep 19, 2019
@agjohnson agjohnson merged commit 0034c1a into master Sep 23, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@agjohnson agjohnson deleted the humitos/allow-extend-domain-create branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.