Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor views ProjectVersion #6175

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Sep 12, 2019

Ref #5856

@stsewd stsewd requested a review from Sep 12, 2019
)


class ProjectVersionDetail(ProjectVersionMixin, UpdateView):
Copy link
Member Author

@stsewd stsewd Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be refactored to be 2 views: detail and update. I can create a separate issue for that.

humitos
humitos approved these changes Oct 2, 2019
Copy link
Member

@humitos humitos left a comment

Looks good. Small comments to consider.

readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 2e76781 into readthedocs:master Oct 2, 2019
2 checks passed
@stsewd stsewd deleted the refactor-views-project-versions branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants