Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor views ProjectUsers #6178

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@stsewd
Copy link
Member

commented Sep 12, 2019

Ref #5856

Ref #5856
@stsewd stsewd requested a review from readthedocs/core Sep 17, 2019
@humitos
humitos approved these changes Oct 2, 2019
return reverse('projects_users', args=[self.get_project().slug])


class ProjectUsersCreateList(ProjectUsersMixin, FormView):

This comment has been minimized.

Copy link
@humitos

humitos Oct 2, 2019

Member

Why we don't use CreateView for these?

This comment has been minimized.

Copy link
@stsewd

stsewd Oct 2, 2019

Author Member

Because this view does two things, list and create. CreatView makes this a model view, we don't want that here.

@stsewd stsewd merged commit c6c918e into readthedocs:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:refactor-views-project-users branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.