Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor views ProjectUsers #6178

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Sep 12, 2019

Ref #5856

@stsewd stsewd requested a review from Sep 17, 2019
humitos
humitos approved these changes Oct 2, 2019
return reverse('projects_users', args=[self.get_project().slug])


class ProjectUsersCreateList(ProjectUsersMixin, FormView):
Copy link
Member

@humitos humitos Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we don't use CreateView for these?

Copy link
Member Author

@stsewd stsewd Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this view does two things, list and create. CreatView makes this a model view, we don't want that here.

@stsewd stsewd merged commit c6c918e into readthedocs:master Oct 2, 2019
2 checks passed
@stsewd stsewd deleted the refactor-views-project-users branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants