Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProjectTranslations views #6185

Merged

Conversation

@stsewd
Copy link
Member

commented Sep 16, 2019

ref #5856

This should be refactored to only use post to delete.

ref #5856
@stsewd stsewd requested a review from readthedocs/core Sep 17, 2019
@humitos
humitos approved these changes Oct 2, 2019
Copy link
Member

left a comment

Code looks good! I just left some minor comments.

readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 494abb3 into readthedocs:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:refactor-project-translations-views branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.