Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove if storage blocks #6191

Merged
merged 2 commits into from Sep 24, 2019

Conversation

@davidfischer
Copy link
Contributor

commented Sep 17, 2019

Storage is now required. By default, storage uses local storage on the filesystem so it doesn't have to be some cloud storage.

- Storage is now required (even if it is just local)
@davidfischer davidfischer requested a review from readthedocs/core Sep 17, 2019
@davidfischer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

I had to put back one check because build servers for RTD for Business are going to temporarily use it.

Copy link
Member

left a comment

Looks good to me.

@stsewd
stsewd approved these changes Sep 17, 2019
@agjohnson agjohnson merged commit 3f3488f into master Sep 24, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@agjohnson agjohnson deleted the davidfischer/remove-if-storage-blocks branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.