Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put view under login #6193

Merged
merged 8 commits into from Oct 9, 2019

Conversation

@stsewd
Copy link
Member

commented Sep 18, 2019

Also, we were implementing our own LoginRequiredMixin, but we already have this on django.

stsewd added 3 commits Sep 18, 2019
Copy link
Member

left a comment

The title of this PR needs some work -- it doesn't explain what view or what this PR is doing :)

@@ -211,7 +210,7 @@ def account_advertising(request):
)


class TokenMixin:

This comment has been minimized.

Copy link
@ericholscher

ericholscher Sep 30, 2019

Member

Is this the actual bugfix here?

This comment has been minimized.

Copy link
@stsewd

stsewd Sep 30, 2019

Author Member

Yeah, otherwise an anonymous user could hit that page, it was returning 500. There was a discussion on slack, sorry for the lack of context.

readthedocs/profiles/views.py Outdated Show resolved Hide resolved
Co-Authored-By: Manuel Kaufmann <humitos@gmail.com>
@stsewd stsewd requested a review from readthedocs/core Oct 2, 2019
@stsewd

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Just for clarification, this PR fix this problem https://readthedocs.org/accounts/tokens/ (enter without being loged in)

Copy link
Member

left a comment

Good refactor 👍

@ericholscher ericholscher merged commit c2166f9 into readthedocs:master Oct 9, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:put-page-under-login branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.