Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved expandable_fields to meta class #6198

Merged
merged 3 commits into from Oct 1, 2019

Conversation

@Iamshankhadeep
Copy link
Contributor

commented Sep 20, 2019

fixes #6159

@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

can anyone tell me why lint is failing?

Copy link
Member

left a comment

This should fix the lint issue :)

readthedocs/api/v3/serializers.py Outdated Show resolved Hide resolved
readthedocs/api/v3/serializers.py Outdated Show resolved Hide resolved
@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

lint is failing because of the space and newline issues? @saadmk11

@saadmk11

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

I think so. You can see the error log from here https://travis-ci.org/readthedocs/readthedocs.org/jobs/587389577

@Iamshankhadeep Iamshankhadeep force-pushed the Iamshankhadeep:expandable_fields_to_meta branch from 2b8bbc1 to 6402c26 Sep 20, 2019
Copy link
Member

left a comment

Thanks for the contribution, but you are only refactoring the expandable_fields attribute. It should be moved to the Meta class.

@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Sorry I do not know what is meta class can you provide me with some link that can help me to learn 'meta class'. Thanks.

@stsewd

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

@Iamshankhadeep you should check the docs for django drf flex fields https://github.com/rsinger86/drf-flex-fields

@stsewd
stsewd approved these changes Sep 26, 2019
Copy link
Member

left a comment

Thanks!

@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

@stsewd dont I have to rebase this pull request?

@stsewd

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@Iamshankhadeep no, it's fine.

@Iamshankhadeep

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

okay @stsewd, Sir thank you a lot for helping me and @saadmk11 thanks for helping me understanding the lint error.

@stsewd stsewd merged commit 0b2e1d5 into readthedocs:master Oct 1, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Iamshankhadeep Iamshankhadeep deleted the Iamshankhadeep:expandable_fields_to_meta branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.