Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Better error message for lists in config file #6200

Merged
merged 4 commits into from Oct 9, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Sep 21, 2019

closes #4914

@saadmk11 saadmk11 requested review from stsewd and Sep 21, 2019
Copy link
Member

@stsewd stsewd left a comment

We should move this to a method, something like get_display_key. And then we should need to add a test for the value of the str(exc)

@saadmk11 saadmk11 requested a review from stsewd Sep 24, 2019
readthedocs/config/config.py Outdated Show resolved Hide resolved
@saadmk11 saadmk11 requested a review from stsewd Sep 25, 2019
stsewd
stsewd approved these changes Sep 25, 2019
Copy link
Member

@stsewd stsewd left a comment

Looks good to me, thanks. Only one suggestion around the static method.

readthedocs/config/config.py Outdated Show resolved Hide resolved
humitos
humitos approved these changes Oct 9, 2019
@humitos humitos merged commit 8fd1fe3 into readthedocs:master Oct 9, 2019
2 checks passed
@saadmk11 saadmk11 deleted the better-error-msg branch Oct 9, 2019
stsewd added a commit to readthedocs/test-builds that referenced this issue Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants