Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Build Active Versions from Build List Page Form #6205

Merged
merged 2 commits into from Sep 30, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Sep 25, 2019

Build list page Build Version form lists the active versions of a project only, but the BuildTriggerMixin does not limit the versions to active only.

@saadmk11 saadmk11 requested a review from Sep 25, 2019
Copy link
Member

@stsewd stsewd left a comment

Great catch! Actually, we should have the exact queryset on the mixin and on the BuildList and ProjectViewDetail context.

We should create a method _get_versions().

@saadmk11 saadmk11 requested a review from stsewd Sep 26, 2019
stsewd
stsewd approved these changes Sep 26, 2019
@ericholscher ericholscher merged commit 9b2bf5a into readthedocs:master Sep 30, 2019
2 checks passed
@saadmk11 saadmk11 deleted the builds-page-bug branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants