Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #6213

Merged
merged 1 commit into from Oct 2, 2019
Merged

Remove dead code #6213

merged 1 commit into from Oct 2, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Sep 26, 2019

This was throwing an exception (it doesn't have a serializer)

This was throwing an exception (it doesn't have a serializer)
@stsewd stsewd requested a review from Sep 26, 2019
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Sep 30, 2019

What was throwing an exception? Is this totally unused, or just part of it?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Sep 30, 2019

It throws the exception because the view doesn't have a serializer, it doesn't work at all.

@humitos
Copy link
Member

@humitos humitos commented Oct 2, 2019

Accessing to https://readthedocs.org/api/v2/notification/ (logged in) throws a 500.

humitos
humitos approved these changes Oct 2, 2019
Copy link
Member

@humitos humitos left a comment

I'm fine removing this since it was broken anyway.

@stsewd stsewd merged commit bcf9f16 into readthedocs:master Oct 2, 2019
2 checks passed
@stsewd stsewd deleted the remove-dead-code branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants