Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the version listview #6224

Merged
merged 2 commits into from Oct 8, 2019
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 1, 2019

Update the version listview screen with the following:

  • No more than 100 inactive versions
  • Filter inactive versions by name
  • Fixes #6070

Screenshot

Screen Shot 2019-09-30 at 11 48 11 PM

- No more than 100 inactive versions
- Filter inactive versions by name
@davidfischer davidfischer requested a review from Oct 1, 2019
@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Oct 1, 2019

I should clarify that the whole "Activate a Version" section only displays for project maintainers just like the previous "Inactive Versions" section it replaces.

stsewd
stsewd approved these changes Oct 1, 2019
@stsewd stsewd requested a review from Oct 1, 2019
humitos
humitos approved these changes Oct 2, 2019
Copy link
Member

@humitos humitos left a comment

Looks good to me.

I'd probably say to just use "Edit" on the button.

@@ -104,7 +119,7 @@ <h1>{% trans "Inactive Versions" %}</h1>

{% if request.user|is_admin:project %}
<ul class="module-item-menu">
<li><a href="{% url "project_version_detail" project.slug version.slug %}">{% trans "Edit" %}</a></li>
<li><a href="{% url "project_version_detail" project.slug version.slug %}">{% trans "Edit & Activate" %}</a></li>
Copy link
Member

@humitos humitos Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the "Edit & Activate" label for the button, but I do not have a better one. Do you think that just "Edit" as it was does not communicate it properly?

Copy link
Contributor

@agjohnson agjohnson Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have the same feeling. The phrase sounds overly specific for a user. Technically, from our perspective, they are editing and activating, but to the user, they are just activating. I think "Activate" is the most correct descriptor for what the user is looking to accomplish, we can gloss over the fact that it drops into a form.

Copy link
Contributor Author

@davidfischer davidfischer Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll update it.

Copy link
Contributor

@agjohnson agjohnson left a comment

Change looks good 👍 , but I'll block on changing the button text. I'll open up a separate issue to describe the flow I was talking about yesterday but didn't have the bandwidth to delve into more. We landed on this as an intermediate fix, a final fix probably relies on SUI anyways.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Oct 4, 2019

I changed the text on that button "Edit & Activate" -> "Activate".

This should be merge ready. For the fix to take effect on RTD for Business where that template is overridden, I will create a corresponding private PR.

@humitos humitos requested a review from agjohnson Oct 7, 2019
@ericholscher ericholscher dismissed agjohnson’s stale review Oct 8, 2019

This was fixed.

@ericholscher ericholscher merged commit 4ee2936 into master Oct 8, 2019
2 checks passed
@ericholscher ericholscher deleted the davidfischer/improve-version-listview branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants