Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use --cache-dir for pip if CLEAN_AFTER_BUILD is enabled #6239

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@humitos
Copy link
Member

commented Oct 2, 2019

Avoid caching pip packages if we are using CLEAN_AFTER_BUILD.

This PR decide when to use --cache-dir or --no-cache-dir based on this setting.

@stsewd what do you think about this? If you think it's OK, I will fix the tests tomorrow.

Related #6236 (comment)

@humitos humitos requested a review from stsewd Oct 2, 2019
Copy link
Member

left a comment

Yeah, I'm ok with this solution 👍

readthedocs/doc_builder/python_environments.py Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

Change looks reasonable 👍

@stsewd
stsewd approved these changes Oct 3, 2019
Copy link
Member

left a comment

Tests are green now

@agjohnson agjohnson merged commit 58f833d into master Oct 3, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@agjohnson agjohnson deleted the humitos/no-cache-if-clean-build branch Oct 3, 2019
agjohnson added a commit that referenced this pull request Oct 3, 2019
* Do not use --cache-dir for pip if CLEAN_AFTER_BUILD is enabled

* Invert conditional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.