Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only post requests for delete views #6242

Merged
merged 3 commits into from Oct 9, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Oct 3, 2019

closes: #6189

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.
Copy link
Member Author

@saadmk11 saadmk11 Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using this here because using a button here doesn't look good also it breaks lot of CSS styles. Would love to get some Suggestions. :)

Copy link
Member

@stsewd stsewd Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a suggestion for this, and also this is something that users shouldn't hit that much.

Copy link
Member

@humitos humitos Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense for now.

I'd appreciate if you add this comment into the template itself (using {# #}) so we know why this done in this way in the future. Thanks!

Copy link
Member Author

@saadmk11 saadmk11 Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humitos Added comment.

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 3, 2019

Thanks, can you attach some screenshots of the final result?

@saadmk11 saadmk11 requested a review from Oct 3, 2019
@saadmk11
Copy link
Member Author

@saadmk11 saadmk11 commented Oct 3, 2019

stsewd
stsewd approved these changes Oct 3, 2019
Copy link
Member

@stsewd stsewd left a comment

LGTM 👍

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.
Copy link
Member

@stsewd stsewd Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a suggestion for this, and also this is something that users shouldn't hit that much.

@stsewd stsewd requested a review from Oct 3, 2019
humitos
humitos approved these changes Oct 9, 2019
Copy link
Member

@humitos humitos left a comment

LGTM! I just left a comment to add a comment in the template.

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.
Copy link
Member

@humitos humitos Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense for now.

I'd appreciate if you add this comment into the template itself (using {# #}) so we know why this done in this way in the future. Thanks!

@humitos humitos merged commit 76ebeff into readthedocs:master Oct 9, 2019
2 checks passed
@saadmk11 saadmk11 deleted the allow-only-post branch Oct 9, 2019
@saadmk11 saadmk11 mentioned this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants