Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only post requests for delete views #6242

Merged
merged 3 commits into from Oct 9, 2019

Conversation

@saadmk11
Copy link
Member

saadmk11 commented Oct 3, 2019

closes: #6189

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Oct 3, 2019

Author Member

I'm using this here because using a button here doesn't look good also it breaks lot of CSS styles. Would love to get some Suggestions. :)

This comment has been minimized.

Copy link
@stsewd

stsewd Oct 3, 2019

Member

I don't have a suggestion for this, and also this is something that users shouldn't hit that much.

This comment has been minimized.

Copy link
@humitos

humitos Oct 9, 2019

Member

I think it makes sense for now.

I'd appreciate if you add this comment into the template itself (using {# #}) so we know why this done in this way in the future. Thanks!

This comment has been minimized.

Copy link
@saadmk11

saadmk11 Oct 9, 2019

Author Member

@humitos Added comment.

@stsewd

This comment has been minimized.

Copy link
Member

stsewd commented Oct 3, 2019

Thanks, can you attach some screenshots of the final result?

@saadmk11 saadmk11 requested a review from readthedocs/core Oct 3, 2019
@saadmk11

This comment has been minimized.

Copy link
Member Author

saadmk11 commented Oct 3, 2019

@stsewd
stsewd approved these changes Oct 3, 2019
Copy link
Member

stsewd left a comment

LGTM 👍

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.

This comment has been minimized.

Copy link
@stsewd

stsewd Oct 3, 2019

Member

I don't have a suggestion for this, and also this is something that users shouldn't hit that much.

@stsewd stsewd requested a review from readthedocs/core Oct 3, 2019
@humitos
humitos approved these changes Oct 9, 2019
Copy link
Member

humitos left a comment

LGTM! I just left a comment to add a comment in the template.

{% blocktrans trimmed %}
This version is inactive but its documentation is still available online.
You can <a href="{{ version_delete_url }}">delete this version's documentation</a> if you want to remove it completely.
You can <a href="#" onclick="document.forms['version_delete_html'].submit();">delete this version's documentation</a> if you want to remove it completely.

This comment has been minimized.

Copy link
@humitos

humitos Oct 9, 2019

Member

I think it makes sense for now.

I'd appreciate if you add this comment into the template itself (using {# #}) so we know why this done in this way in the future. Thanks!

@humitos humitos merged commit 76ebeff into readthedocs:master Oct 9, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saadmk11 saadmk11 deleted the saadmk11:allow-only-post branch Oct 9, 2019
@saadmk11 saadmk11 mentioned this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.