Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #6176 to master #6258

Merged
merged 20 commits into from Oct 9, 2019

Conversation

@stsewd
Copy link
Member

commented Oct 8, 2019

This PR wasn't merged to master, but /humitos/apiv3/project-update-endpoint. I don't see anything blocking this to make it to master.

#6176

humitos and others added 18 commits Sep 10, 2019
`self` is either ChildRelatedProjectQuerySet or
ParentRelatedProjectQuerySet. None of these one has a `project`
field. Because of this, we need to use `self.project_field` for lookup.
…om:readthedocs/readthedocs.org into humitos/subproject-api-projectrelationship
- Adding the project as subproject of itself
- Nesting subprojects is not supported
- Unique alias across subprojects of project
…project-api-projectrelationship
…adthedocs/readthedocs.org into humitos/subproject-api-projectrelationship
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
…ectrelationship

Create subproject relationship via APIv3 endpoint
@stsewd

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

Changes are the same as #6176 + linter fixes

@stsewd stsewd requested a review from readthedocs/core Oct 8, 2019
@humitos
humitos approved these changes Oct 9, 2019
@humitos humitos changed the title Merge #6176 to master Merge #6176 to master Oct 9, 2019
@humitos humitos merged commit 5f145f1 into master Oct 9, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/apiv3/project-update-endpoint branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.