Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inactive version list not showing when no resuts returned #6264

Merged
merged 2 commits into from Oct 9, 2019

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 9, 2019

Previously it would hide the UI when users search
for a term with no matching versions

Previously it would hide the UI when users search
for a term with no matching versions
humitos
humitos approved these changes Oct 9, 2019
Copy link
Member

@humitos humitos left a comment

Change makes sense.

We may want to add an {% empty %} block as well saying that there is no versions matching the filter/search.

@ericholscher ericholscher added the PR: hotfix label Oct 9, 2019
@humitos humitos merged commit 6a0a2c2 into master Oct 9, 2019
3 checks passed
@humitos humitos deleted the fix-inactive-version-list-not-showing branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants