Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor profile's views #6267

Merged
merged 6 commits into from Oct 15, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Oct 9, 2019

There were some views that accepted some additional context, but it wasn't used on .com nor on the ext repo.

@stsewd stsewd requested a review from readthedocs/core Oct 9, 2019
Copy link
Member

humitos left a comment

Looks good to me!

There were some views that accepted some additional context, but it wasn't used on .com nor on the ext repo.

I suppose that this was the old way to change behavior from the corporate site (instead of using the override class settings). Maybe @agjohnson or @ericholscher can confirm that this is old and not needed anymore.

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 15, 2019

Yea, this code was copied from django-profiles, which was built like a reusable Django app. If we aren't using it, we likely don't need it.

@stsewd stsewd merged commit 2445f46 into readthedocs:master Oct 15, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:refactor-profiles-view branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.