Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #6269

Merged
merged 2 commits into from Oct 10, 2019
Merged

Fix tests #6269

merged 2 commits into from Oct 10, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 10, 2019

This is required to fix the tests on .com

Each commit has the why for each change.

stsewd added 2 commits Oct 10, 2019
Some parts of the code still depend
of some minimal middlewares.
@stsewd stsewd requested a review from Oct 10, 2019
Copy link
Member

@ericholscher ericholscher left a comment

I don't fully understand this, but seems reasonable. We should probably lint for this if we can, to stop it from happening in the future.

@ericholscher ericholscher merged commit 2bd2dac into master Oct 10, 2019
3 checks passed
@ericholscher ericholscher deleted the stsewd/fix-tests branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants