Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gold Views #6272

Merged
merged 2 commits into from Dec 2, 2019
Merged

Refactor Gold Views #6272

merged 2 commits into from Dec 2, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Oct 10, 2019

closes #5856

Changed a bit of the template otherwise had to do hack like this: #6242 (comment)
Screenshot from 2019-10-10 19-41-49

@saadmk11 saadmk11 requested review from and stsewd Oct 10, 2019
stsewd
stsewd approved these changes Oct 11, 2019
Copy link
Member

@stsewd stsewd left a comment

Thanks!

@stsewd stsewd requested a review from Oct 17, 2019
Copy link
Contributor

@agjohnson agjohnson left a comment

There are a couple fixes on the template that I noted, but changes look good otherwise 👍

<li>
<form method="post" action="{% url "gold_projects_remove" project.slug %}">
{% csrf_token %}
<input type="submit" value="{% trans 'Remove Ad-Free Status' %}">
Copy link
Contributor

@agjohnson agjohnson Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ad free status is a lot for a button, it's better to keep text on buttons to a minimum or rely on icons instead. When translators go to translate this string, it could easily become a string that is too wide for the list view.

Copy link
Member Author

@saadmk11 saadmk11 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a tool tip with the remove button.

Screenshot from 2019-10-31 17-41-03

{% endfor %}
</ul>

<div class="module-translation">
Copy link
Contributor

@agjohnson agjohnson Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be module-translation, which is referencing the translation admin UI.

@saadmk11 saadmk11 requested a review from agjohnson Oct 31, 2019
@agjohnson agjohnson merged commit 2a1b641 into readthedocs:master Dec 2, 2019
2 checks passed
@saadmk11 saadmk11 deleted the gold-refactor branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants