Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer #6274

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Oct 10, 2019

It wasn't rendering correctly

It wasn't rendering correctly
@stsewd stsewd requested a review from readthedocs/core Oct 10, 2019
@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 14, 2019

Is there a way to check for this in tests? Feels like something we should be finding automatically.

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 14, 2019

we have tests that hit this template, but it wasn't raising a syntax error, it was just rendering it wrong :/

@stsewd stsewd merged commit b61663b into readthedocs:master Oct 14, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:fix-footer branch Oct 14, 2019
@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 15, 2019

we have tests that hit this template, but it wasn't raising a syntax error, it was just rendering it wrong :/

How can we make the test raise a syntax error?

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 15, 2019

Opened #6290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.