Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint #6317

Merged
merged 6 commits into from Oct 25, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Oct 21, 2019

I just rebuilt the js assets.

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 21, 2019

pinning the node version worked! :)

@stsewd stsewd requested a review from readthedocs/core Oct 21, 2019
Copy link
Member

humitos left a comment

The changes look good to me.

I don't have a strong opinion here because I don't have too much experience.

It seems the current LTS version is v12.x. Was that the problem? Why it does not build with the latest LTS version?

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 22, 2019

It seems the current LTS version is v12.x. Was that the problem? Why it does not build with the latest LTS version?

That's the problem the linter is given, guess they updated the lts version.

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 22, 2019

yup, they updated the LTS version from v10 to v12 https://nodejs.org/en/download/releases/ a couple of days ago

Copy link
Contributor

agjohnson left a comment

Change looks good! I don't think we should have JS changes added here though. What changed here to generate new JS?

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 23, 2019

What changed here to generate new JS?

Nothing I guess, just built them to make sure we have the latest files.

@stsewd stsewd force-pushed the stsewd:fix-eslint branch from b7a65c7 to bf7ffd3 Oct 23, 2019
@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 23, 2019

@agjohnson js files are omited now

@stsewd stsewd requested a review from agjohnson Oct 23, 2019
@agjohnson

This comment has been minimized.

Copy link
Contributor

agjohnson commented Oct 24, 2019

There is something that happens here, and it's hard to tell if anything even changed in the built assets. In my environment, I always generate new assets, different from everyone else. I had to have David do the build steps on last release because my environment was re-creating all the assets -- his didn't recreate anything 😕

.travis.yml Outdated Show resolved Hide resolved
@stsewd stsewd requested a review from agjohnson Oct 24, 2019
@agjohnson agjohnson merged commit f5dbf2c into readthedocs:master Oct 25, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:fix-eslint branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.