Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files from storage and delete indexes from ES when no longer needed #6323

Merged
merged 5 commits into from Nov 5, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Oct 22, 2019

Currently, we are not removing files from storage when a version is deactivated. And we are not removing indexes from ES when a project/version is deleted or a version is deactivated.

Have to refactor remove_indexed_files to accept a slug instead of an instance, so we avoid having to make a query.

@stsewd stsewd force-pushed the stsewd:clean-project-resources branch from a2b4cb1 to ccddefd Oct 22, 2019
@stsewd stsewd requested a review from readthedocs/core Oct 22, 2019
@stsewd stsewd force-pushed the stsewd:clean-project-resources branch from ccddefd to a2eb682 Oct 22, 2019
@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Oct 22, 2019

Tested this locally, it's ready for review. Test faillin is fixed in #6317

@stsewd stsewd merged commit dde41e8 into readthedocs:master Nov 5, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:clean-project-resources branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.