Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 6.0rc1 build image #6329

Merged
merged 3 commits into from Oct 31, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Oct 24, 2019

This is basically the same as #6327, with tests fixed.

Users get python 3.8 only if they have python: 3 as version (not if they have python: 3.x) or aren't using a configuration file and have python3 set on the web UI.

readthedocs/readthedocs-docker-images#111 is needed.

stsewd added 2 commits Oct 24, 2019
Copy link
Member

humitos left a comment

Looks good to me.

eslint test are failing but it's not related to this PR.

Copy link
Contributor

agjohnson left a comment

Changes looks good 👍

We need an ops PR that adds the image to the build servers. I'll set to block, feel free to unblock once we have that PR merged.

@humitos humitos merged commit 29f603a into readthedocs:master Oct 31, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@humitos humitos mentioned this pull request Oct 31, 2019
@stsewd stsewd deleted the stsewd:support-6.0rc1-build-image branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.