Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont link to dashboard from footer #6353

Merged

Conversation

@stsewd
Copy link
Member

stsewd commented Nov 6, 2019

We use the get_absolute_url in other parts of the code
where it makes sense to link to the dashboard.
So I'm adding an additional parameter.

Closes #6137

stsewd added 2 commits Nov 6, 2019
Closes #6137

We use the `get_absolute_url` in other parts of the code
where it makes sense to link to the dashboard.
So I'm adding an additional parameter.
@stsewd stsewd requested a review from readthedocs/core Nov 6, 2019
Fix tests
We were testing with non-build versions.
But in production is more common to hit this with build versions.
@@ -235,11 +240,12 @@ class TestFooterPerformance(APITestCase):

# The expected number of queries for generating the footer
# This shouldn't increase unless we modify the footer API
EXPECTED_QUERIES = 9
EXPECTED_QUERIES = 13

This comment has been minimized.

Copy link
@ericholscher

ericholscher Nov 7, 2019

Member

Hmm, this is less than ideal. Is this some number of additional queries for each version?

This comment has been minimized.

Copy link
@stsewd

stsewd Nov 7, 2019

Author Member

The explanation is the commit

We were testing with non-build versions.
But in production is more common to hit this with build versions.

This comment has been minimized.

Copy link
@stsewd

stsewd Nov 7, 2019

Author Member

That number is the "normal" number of queries, we were testing for a no common case where the version wasn't built

This comment has been minimized.

Copy link
@ericholscher

ericholscher Nov 7, 2019

Member

Ah I see, it's in the version_compare data. I wonder if we should be caching this, seems simple enough to cache if it's a lot of our footer queries.

This comment has been minimized.

Copy link
@ericholscher

ericholscher Nov 7, 2019

Member

I will never look at commit messages in PR's, so it's probably better to put it in the PR description.

Copy link
Member

ericholscher left a comment

Looks good 👍

@ericholscher ericholscher merged commit 2f97d8b into readthedocs:master Nov 7, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stsewd added a commit to stsewd/readthedocs.org that referenced this pull request Nov 7, 2019
@stsewd stsewd deleted the stsewd:dont-link-to-dashboard-from-footer branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.