Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default of proxied_api_host to api_host #6355

Merged
merged 4 commits into from Nov 7, 2019

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 7, 2019

This allows us to respect the api_host that might be configured
in pre-built documentation.
Previously these would all default to readthedocs.org,
which isn't great for local dev or custom installs.

This allows us to respec the ``api_host`` that might be configured
in pre-built documentation.
Previously these would all default to ``readthedocs.org``,
which isn't great for local dev or custom installs.
@ericholscher ericholscher requested a review from stsewd Nov 7, 2019
stsewd
stsewd approved these changes Nov 7, 2019
Copy link
Member

@stsewd stsewd left a comment

You are right 👍 we need to rebuild the assets.

ericholscher and others added 2 commits Nov 7, 2019
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
@stsewd stsewd merged commit 6484b56 into master Nov 7, 2019
3 checks passed
@stsewd stsewd deleted the change-proxied-api-default branch Nov 7, 2019
stsewd added a commit that referenced this issue Mar 10, 2020
This reverts:
- #6355
- #6131

And force the use of the proxied api to all docs.
This wasn't done before because .com wasn't ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants