Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare inactive or non build versions #6361

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Nov 7, 2019

This is a better approach for #6353

This is a better approach for #6353
@stsewd stsewd requested a review from readthedocs/core Nov 7, 2019
Copy link
Member

ericholscher left a comment

👍

@humitos

This comment has been minimized.

Copy link
Member

humitos commented Nov 7, 2019

I'm not sure to understand how this PR works. It's linked to the issue "List only built versions on the footer" (#6137) but from what I understand here, it just does not consider build=False and active=False when comparing versions to know which one is the highest.

Although, I'm not sure why or where this will affect to the versions shown in the footer.

@humitos

This comment has been minimized.

Copy link
Member

humitos commented Nov 7, 2019

Is this "hidden feature" (#6137 (comment)) still possible after this PR is merged?

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Nov 7, 2019

@humitos got confused where this is used. This is only used to show the banner You are seeing an old version, there is a new one here... To get the urls from the footer we call get_subdomain_url which calls to resolve directly.

@stsewd

This comment has been minimized.

Copy link
Member Author

stsewd commented Nov 7, 2019

@humitos

<dd><a href="{{ version.get_subdomain_url }}{{ path|default_if_none:"" }}">{{ version.slug }}</a></dd>

@stsewd stsewd merged commit 810afe6 into readthedocs:master Nov 7, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:dont-compare-non-build-versions branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.