Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force PUBLIC_DOMAIN_USES_HTTPS on version compare tests #6367

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@humitos
Copy link
Member

humitos commented Nov 11, 2019

This setting is the one used in production as True. So, this helps us to make the tests closer to prod but also to make them pass on corporate where we force require_https in the resolver.

This setting is the one used in production as `True`. So, this helps
us to make the tests closer to prod but also to make them pass on
corporate where we force `require_https` in the resolver.
@humitos humitos requested a review from stsewd Nov 11, 2019
@stsewd
stsewd approved these changes Nov 11, 2019
@humitos humitos merged commit 4392846 into master Nov 11, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/use-https-tests branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.