Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upForce PUBLIC_DOMAIN_USES_HTTPS on version compare tests #6367
Conversation
This setting is the one used in production as `True`. So, this helps us to make the tests closer to prod but also to make them pass on corporate where we force `require_https` in the resolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
humitos commentedNov 11, 2019
This setting is the one used in production as
True. So, this helps us to make the tests closer to prod but also to make them pass on corporate where we forcerequire_httpsin the resolver.