Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search indexing #6380

Merged
merged 1 commit into from Nov 14, 2019
Merged

Fix search indexing #6380

merged 1 commit into from Nov 14, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 14, 2019

Each method returns a new object,
it doesn't modify the current one

Each method returns a new object,
it doesn't modify the current one
Copy link
Member

@ericholscher ericholscher left a comment

I'm a little worried that our tests didn't catch this. I guess we aren't indexing multiple versions at once and then searching across them :/

@ericholscher ericholscher added the PR: hotfix label Nov 14, 2019
@stsewd stsewd merged commit 1c9a4e6 into master Nov 14, 2019
3 checks passed
@stsewd stsewd deleted the fix-search branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants