Skip to content

/readthedocs.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search indexing #6380

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@stsewd
Copy link
Member

stsewd commented Nov 14, 2019

Each method returns a new object,
it doesn't modify the current one
@stsewd
Fix search indexing
Loading status checks…
20fb155 
Each method returns a new object,
it doesn't modify the current one
@ericholscher
ericholscher approved these changes Nov 14, 2019
View changes
Copy link
Member

ericholscher left a comment

I'm a little worried that our tests didn't catch this. I guess we aren't indexing multiple versions at once and then searching across them :/
@davidfischer
davidfischer approved these changes Nov 14, 2019
View changes
@stsewd stsewd mentioned this pull request Nov 14, 2019
Open
@stsewd stsewd merged commit 1c9a4e6 into master Nov 14, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@stsewd stsewd deleted the fix-search branch Nov 14, 2019
@stsewd stsewd mentioned this pull request Dec 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher

@davidfischer davidfischer

Assignees
No one assigned
Labels
PR: hotfix
Projects
None yet
Milestone
No milestone
3 participants
@stsewd @ericholscher @davidfischer
You can’t perform that action at this time.