Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.10.0 #6391

Merged
merged 2 commits into from Nov 19, 2019
Merged

Release 3.10.0 #6391

merged 2 commits into from Nov 19, 2019

Conversation

@ericholscher
Copy link
Member

ericholscher commented Nov 19, 2019

No description provided.

@stsewd
stsewd approved these changes Nov 19, 2019
Copy link
Member

stsewd left a comment

Not sure if we wanted to update the package-lock.json file on a release, otherwise 👍

@humitos

This comment has been minimized.

Copy link
Member

humitos commented Nov 19, 2019

I think the package lock file should not change. Last deploy, we realize that we need to use npm ci install of npm install.

@ericholscher

This comment has been minimized.

Copy link
Member Author

ericholscher commented Nov 19, 2019

Yea, the package-lock.json file was updated when I ran npm install npm, because the version of NPM I had didn't have npm ci. The beauty of software. I've reverted it.

@ericholscher ericholscher merged commit ff0ad67 into master Nov 19, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@ericholscher ericholscher deleted the release/3.10.0 branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.