Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS and how we were handling html in automation rule UI #6394

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@agjohnson
Copy link
Contributor

agjohnson commented Nov 19, 2019

Remove hard coded values in HTML for font awesome and override the
values with CSS instead.

The problem with how the underlying PR is written is that normally all of this is done with CSS, the values are not hard coded in the HTML. We can't override this on commercial styling as easy when we hardcode the value into HTML. This is a better example of how to do CSS, classes on the module and module elements, and how to add a font awesome icon to a button.

@agjohnson

This comment has been minimized.

Copy link
Contributor Author

agjohnson commented Nov 19, 2019

image

Updated the fixes for CSS, looks better now.

Remove hard coded values in HTML for font awesome and override the
values with CSS instead.
@agjohnson agjohnson force-pushed the hotfix/fix-ui-automationrule branch from bb5d11e to 0d33f68 Nov 19, 2019
@agjohnson agjohnson requested a review from stsewd Nov 19, 2019
@stsewd
stsewd approved these changes Nov 19, 2019
@humitos humitos merged commit 339a4c2 into master Nov 26, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the hotfix/fix-ui-automationrule branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.