Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate El Proxito views to class-based views #6396
Merged
Conversation
humitos
force-pushed the
humitos/proxito-class-based-views
branch
from
d4ab6bc
to
f3728ac
This was referenced Nov 20, 2019
|
This looks good and makes sense to me. Having things split up into more files makes it a lot easier to understand, instead of one huge views.py I'm happy to merge this and start testing it locally for our dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
humitos commentedNov 20, 2019
This PR just refactor El Proxito views to make them class based views. The advantage of this is that it will allow us to extend these views from corporate and change the behavior required to serve authed documentation.
There is no logic changes in this PR, just moving code around proposing a file structure where to put each file for
proxitodjango app.I didn't migration the redirect views because I think it's not needed at this point.