Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate El Proxito views to class-based views #6396

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@humitos
Copy link
Member

humitos commented Nov 20, 2019

This PR just refactor El Proxito views to make them class based views. The advantage of this is that it will allow us to extend these views from corporate and change the behavior required to serve authed documentation.

There is no logic changes in this PR, just moving code around proposing a file structure where to put each file for proxito django app.

I didn't migration the redirect views because I think it's not needed at this point.

@humitos humitos requested a review from ericholscher Nov 20, 2019
@humitos humitos force-pushed the humitos/proxito-class-based-views branch from d4ab6bc to f3728ac Nov 20, 2019
Copy link
Member

ericholscher left a comment

This looks good and makes sense to me. Having things split up into more files makes it a lot easier to understand, instead of one huge views.py 👍

I'm happy to merge this and start testing it locally for our dev.

@humitos humitos merged commit 6efee5f into master Nov 23, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/proxito-class-based-views branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.