Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extend El Proxito views from commercial #6397

Merged
merged 2 commits into from Nov 24, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 20, 2019

This is useful in commercial site to override allowed_user method to the required auth checks and decide if the file should be served to the user or not.

In the community site, this method should always return True since all projects/versions are public.

This is all the code changes required in the community site. Feel free to suggest a better pattern or better names for the methods.

This PR is based on #6396

Copy link
Member

@ericholscher ericholscher left a comment

I was hoping to have cleaner logic around this, so this makes sense to me as a starting point 👍. It would be cool if it was a mixin that was used elsewhere in our views, so we only have the logic in one place, but we can work towards that.

@humitos humitos changed the base branch from humitos/proxito-class-based-views to master Nov 23, 2019
@humitos
Copy link
Member Author

@humitos humitos commented Nov 23, 2019

Yes. I'm not super happy with this design. Although, I didn't come up with a better one. As you said, the can find out a better solution later while we start testing/developing what we need in commercial. The change is not too big even if we want to change the direction later.

@humitos humitos merged commit d90f37d into master Nov 24, 2019
3 checks passed
@humitos humitos deleted the humitos/proxito-authed-serve-docs branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants